Repository navigation
Conversation
rmdes
marked this pull request as ready for review
October 13, 2026 13:00
paulrobertlloyd
force-pushed
the
main
branch
2 times, most recently
from
October 13, 2026 18:24
2f22f32 to
b791821
Compare
Likes and reposts were only syndicated when the status was on the syndicator's own server; a status on any other instance was skipped and reported as not returning a URL. Resolve such statuses the same way replies already are (resolveRemoteStatus), so they become native favourites and reblogs. URLs that don't resolve to a status are still not syndicated. Refs #843
rmdes
force-pushed
the
fix/syndicator-mastodon-cross-server-likes
branch
from
October 14, 2026 10:46
90b6462 to
861ece7
Compare
paulrobertlloyd
force-pushed
the
main
branch
4 times, most recently
from
October 19, 2026 20:46
0cd6019 to
fb507d2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #843.
Likes and reposts are syndicated as native favourites and reblogs, but only when the status is on the syndicator's own server. Liking a status on any other instance is skipped, and
endpoint-syndicatereports it as "did not return a URL". Without the ActivityPub plugin, that's the only route a like has to the fediverse, so for most likes nothing happens.Replies already resolve statuses on other servers (
resolveRemoteStatus, #927). This uses the same step for likes and reposts:postFavouriteandpostReblogtake the status ID from the URL when the status is on this server, and otherwise resolve it withv2/search(resolve: true).post()no longer drops likes and reposts of other servers' URLs up front.Opt-in statuses for likes and reposts of URLs that aren't statuses (
syndicateExternalLikes/syndicateExternalReposts) can follow separately, depending on the discussion in #843.Tests
post(), quote statuses of a remote status, and skipping URLs that don't resolve.endpoint-syndicateandendpoint-sharesyndication tests pass (73/73, Node 24.17).