feat(ember): Give component definition lookups their own span op - #24271
Open
Lms24 wants to merge 2 commits into
Open
feat(ember): Give component definition lookups their own span op#24271Lms24 wants to merge 2 commits into
Lms24 wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-ember-ui-resolve-op
branch
from
September 11, 2026 11:25
43fa11f to
0cecb34
Compare
Lms24
marked this pull request as ready for review
September 11, 2026 12:11
Lms24
requested review from
mydea and
s1gr1d
and removed request for
a team
September 11, 2026 12:11
Ember spans that resolve a component definition were using the `function` op, which infers a span description of "Function execution" and loses the component name. They now use `ui.resolve`, a new op proposed in getsentry/sentry-conventions#633. The op is hard-coded with a TODO until that lands and we can import the const. Route hook spans keep the route as `sentry.description` and are named after the hook when span streaming is on, so the name matches `code.function.name` (the `function` op's name template) in both trace lifecycles. Also converts the `ember-classic` E2E app to span streaming and turns on `enableComponentDefinitions` there, so `ui.resolve` gets covered. That flag was off in every app, so the code path had never run in CI. `ember-embroider` and `ember-vite` still cover the static lifecycle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-ember-ui-resolve-op
branch
from
September 11, 2026 12:41
0cecb34 to
698513f
Compare
s1gr1d
approved these changes
Sep 11, 2026
| _processComponentRenderAfter(payload as Payload, beforeComponentDefinitionEntries, FUNCTION, 0); | ||
| // TODO: Use the `UI_RESOLVE` const from `@sentry/conventions/op` once the op is released. | ||
| // See https://github.com/getsentry/sentry-conventions/pull/633 | ||
| _processComponentRenderAfter(payload as Payload, beforeComponentDefinitionEntries, 'ui.resolve', 0); |
Member
Author
There was a problem hiding this comment.
Only merged yet, not released. Needs a 0.24.0 release of conventions, so I think fine to merge as-is in the meantime
Lms24
commented
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember spans that resolve a component definition used the
functionop, which infers a description of "Function execution" and loses the component name. Switching them toui.renderwould have collided with the render span that follows it: same name, sameui.component_name. So they now useui.resolve, a new op proposed in getsentry/sentry-conventions#633. It is hard-coded with a TODO until that lands and we can import the const.This PR:
ui.resolveop, in both trace lifecycles — unlike names, ops are not gated on span streamingbeforeModel,model, …) when span streaming is enabled, which is thefunctionop's{{code.function.name}}name templatesentry.description, but only when streaming: in the static lifecycle the span name is still the route, so the attribute would just duplicate it. Same call@sentry/angular'sTraceMethodmakes.enableComponentDefinitionsin theember-classicE2E app, which is what coversui.resolve— the flag was off in every app, so the code path had never run in CIMIGRATION.mdref #23954
🤖 Generated with Claude Code