Skip to content

[java] Fix broken LICENSE link in java/README.md - #2553

Open
rinceyuan wants to merge 1 commit into
github:mainfrom
rinceyuan:docs/java-license-link
Open

[java] Fix broken LICENSE link in java/README.md#2553
rinceyuan wants to merge 1 commit into
github:mainfrom
rinceyuan:docs/java-license-link

Conversation

@rinceyuan

Copy link
Copy Markdown
Contributor

The License section of java/README.md links to sdk/LICENSE, which resolves to java/sdk/LICENSE — a path that does not exist. The link 404s on GitHub.

No java-local LICENSE has ever been tracked in this repository, so the link has been dead since it was introduced; the java/srcjava/sdk restructure in #2301 only changed which nonexistent path it pointed at (LICENSEsdk/LICENSE). This retargets it to the repository-root ../LICENSE.

Verification

The only LICENSE files tracked in the repo:

$ git ls-files | grep LICENSE
LICENSE
rust/LICENSE

java/LICENSE was never tracked, so the pre-restructure link was dead too:

$ git log --oneline --all -- java/LICENSE
                      # (no output)
$ git ls-tree d9a6fabb^ java/ --name-only | grep LICENSE
                      # (no output — java/LICENSE absent before the move as well)

Before / after, resolved relative to java/README.md:

Link target Resolves to Exists
sdk/LICENSE (before) java/sdk/LICENSE
../LICENSE (after) LICENSE

Scope

One line in one file. java/README.md is the only README that links to a LICENSE file — nodejs, go, and dotnet each render a bare MIT under ## License, and rust/python have no License section at all — so nothing else is affected.

The License section pointed at java/sdk/LICENSE, which does not exist. No java-local LICENSE has ever been tracked; the only LICENSE files in the repo are the root LICENSE and rust/LICENSE. Retarget the link to the repository-root ../LICENSE.
Copilot AI balanced review requested due to automatic review settings September 7, 2026 01:49
@rinceyuan
rinceyuan requested a review from a team as a code owner September 7, 2026 01:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The link-only change correctly targets the existing root license, with no unresolved issues.

Pull request overview

Fixes the broken license link in the Java README by pointing to the repository-root license.

Changes:

  • Updates sdk/LICENSE to ../LICENSE.
File summaries
File Description
java/README.md Corrects the MIT license link.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants