Skip to content

Fix update-protocol-version.ts templates that break the Go and .NET builds #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rinceyuan wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

Fix update-protocol-version.ts templates that break the Go and .NET builds #2554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions nodejs/scripts/update-protocol-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* - go/sdk_protocol_version.go
* - python/copilot/_sdk_protocol_version.py
* - dotnet/src/SdkProtocolVersion.cs
* - rust/src/sdk_protocol_version.rs
*
* Run this script whenever the protocol version changes.
*/
Expand Down Expand Up @@ -56,13 +57,13 @@ const goCode = `// Code generated by update-protocol-version.ts. DO NOT EDIT.

package copilot

// SdkProtocolVersion is the SDK protocol version.
// SDKProtocolVersion is the SDK protocol version.
// This must match the version expected by the copilot-agent-runtime server.
const SdkProtocolVersion = ${version}
const SDKProtocolVersion = ${version}

// GetSdkProtocolVersion returns the SDK protocol version.
func GetSdkProtocolVersion() int {
return SdkProtocolVersion
// GetSDKProtocolVersion returns the SDK protocol version.
func GetSDKProtocolVersion() int {
return SDKProtocolVersion
}
`;
fs.writeFileSync(path.join(rootDir, "go", "sdk_protocol_version.go"), goCode);
Expand Down Expand Up @@ -95,7 +96,7 @@ console.log(" ✓ python/copilot/_sdk_protocol_version.py");
// Generate C#
const csharpCode = `// Code generated by update-protocol-version.ts. DO NOT EDIT.

namespace GitHub.Copilot.SDK;
namespace GitHub.Copilot;

/// <summary>
/// Provides the SDK protocol version.
Expand Down