Repository navigation
fix(test): run the unit:integrations vitest project from the root scripts - #1157
Merged
Merged
Conversation
…ipts The `unit:integrations` project is defined in vitest.config.ts, but the root `test`, `test:unit` and `test:coverage` scripts select projects by name and never listed it, so `integrations/test/**` was skipped in CI while `coverage.include` still counted `integrations/src/**`. Every line in the package was reported as uncovered, which went unnoticed while it held only `index.ts` and `version.ts` but pushes the repo-wide thresholds below the limit now that it ships real models (#1125, #1140).
sasha-gitg
approved these changes
Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
@google/adk-integrationswas not participating in tests or coverage.vitest.config.tsdefines aunit:integrationsproject (integrations/test/**/*_test.ts), but the roottest,test:unitandtest:coveragescripts inpackage.jsonselect projects by name and never listed it, so its tests were skipped in CI whilecoverage.includestill countedintegrations/src/**/*.ts. Every line in the package was therefore reported as 0% covered.This went unnoticed while the package held only
index.ts/index_web.ts/version.ts, but now that it ships real code (#1125, and #1140 on top of it) the uncovered lines push the repo-wide thresholds below 92/85/94/92 and failrun-tests.Solution:
Add
--project unit:integrationsto the three root scripts. No vitest config change is needed; the project was already correctly defined.Testing Plan
Unit Tests:
npm run test:coverageon this branch:The
unit:integrationsproject alone runs 3 files / 64 tests (version_test.ts,models/anthropic_llm_test.ts,models/anthropic_utils_test.ts), which previously never executed undernpm testor in CI.Checklist
Additional context
#1140 should go green once this lands on
mainand the PR is rebased.