Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single four-element
u16array to demonstrate the bytes-versus-elements mistake inslice::from_raw_parts. RemovingKeyPair,repr(C), and the adjacent private-key array keeps the example focused on the unsafe function's safety requirements. The speaker notes identify the length mismatch and give a live edit that restores the correct slice length.The starting example intentionally remains unsound, as required by the lesson.
Fixes #2733.
Validation:
nightly-2025-09-01reports the expected undefined behavior: the slice requires 16 bytes but the array provides 8.[1, 2, 3, 4].mdbook build, including the local link check.mdbook serve: the changed page returns HTTP 200 with the simplified example and updated notes.dprint check src/unsafe-rust/unsafe-functions/calling.mdandgit diff --check.Local setup:
cargo xtask install-toolshit athiserror_implE0463 error in Bazel on macOS. The repository tool versions were installed with Cargo for the checks above.