Conversation
gherrit-pr-id: Gfa0cb30780189c43bb84da57a9ade4d5a9754223
...so that they consume an `IntoBytes` as their source. Since these methods are private, this does not yet increase expressivity for users, but nonetheless allows the compiler to better optimize existing callsites. For example, the `ref_from_prefix_dynamic_size` benchmark becomes branchless, shrinking from 14 to 9 instructions. The falible suffix-with-elems benchmarks shrink from 24 to 17 instructions for dynamic size, and 28 to 20 instructions for dynamic padding. Only `try_ref_from_prefix_dynamic_size` regresses, from 19 to 20 instructions. gherrit-pr-id: Gd1b460a8ec2e8aa8adf2e070c329d9f209c7c89c
This was referenced Sep 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gd1b460a8ec2e8aa8adf2e070c329d9f209c7c89c #3712 +/- ##
=============================================================================
+ Coverage 92.51% 92.64% +0.12%
=============================================================================
Files 20 20
Lines 6362 6429 +67
=============================================================================
+ Hits 5886 5956 +70
+ Misses 476 473 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12bc48fa9b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
joshlf
requested changes
Sep 22, 2026
Refactors these routines to not depend on padding byte preservation across moves. Along the way, we make the `try_read_from` helper safe, generic, and better-optimized. Instruction counts for the `try_read_from_*` change by -36% to -55%. gherrit-pr-id: G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e
jswrenn
force-pushed
the
G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e
branch
from
September 23, 2026 20:36
12bc48f to
d4c0f5e
Compare
This was referenced Sep 23, 2026
joshlf
approved these changes
Sep 23, 2026
Base automatically changed from
Gd1b460a8ec2e8aa8adf2e070c329d9f209c7c89c
to
main
September 24, 2026 01:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors these routines to not depend on padding byte preservation
across moves. Along the way, we make the
try_read_fromhelper safe,generic, and better-optimized. Instruction counts for the
try_read_from_*change by -36% to -55%.CastType::Exactinstead of reusingPrefixfor exact casts #3717validate_cast_and_convert_metadata#3716TryFromBytes::try_read_from*#3712(try_)ref_from_prefix_suffix#3711ReadOnly#3682Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e && git checkout -b pr-G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e FETCH_HEADCheckout
git fetch origin refs/heads/G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G35c8b8db33f4c984d5716af9a26c0a5ec9bd9c7e && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.