feat(spanner): add OPAQUE cryptographic engine and protobufs for Omni authentication - #18300
Open
sagnghos wants to merge 2 commits into
Open
feat(spanner): add OPAQUE cryptographic engine and protobufs for Omni authentication#18300sagnghos wants to merge 2 commits into
sagnghos wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces OPAQUE protocol cryptographic utilities and connection helpers for Spanner Omni authentication, including P-256 elliptic curve operations, hash-to-curve mapping, and a UserAuthenticator class. The review feedback highlights three key areas for improvement: resolving a runtime TypeError caused by concatenating bytes and bytearray in expand_message_xmd, enforcing a minimum hash_size of 8 bytes to prevent downstream Argon2id salt length errors, and implementing a clear method and destructor on UserAuthenticator to securely zeroize sensitive cryptographic state in memory if a handshake is aborted.
sagnghos
force-pushed
the
sagnghos/omni-opaque-crypto
branch
2 times, most recently
from
September 8, 2026 14:02
9022598 to
db5d34d
Compare
… authentication - Add generated protobuf and gRPC definitions for Omni authentication and login - Add OPAQUE protocol cryptographic primitives, RFC 9380 hash-to-curve, Argon2id stretch, and key derivation - Add UserAuthenticator state machine for initial and final request generation - Add cryptography >= 44.0.0 dependency - Add comprehensive unit tests achieving 100% statement and branch coverage
sagnghos
force-pushed
the
sagnghos/omni-opaque-crypto
branch
from
September 8, 2026 14:10
db5d34d to
bd9007b
Compare
…ize, and memory zeroization
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is PR 1 of 3 breaking down the Spanner Omni authentication feature into smaller, reviewable increments.
Reference: #18273
This PR adds:
authentication_pb2*,login_pb2*).opaque.py), including NIST P-256 elliptic curve arithmetic, RFC 9380expand_message_xmdand Simplified SWU hash-to-curve, Argon2id stretch key stretching, Diffie-Hellman key exchange, envelope recovery, and the clientUserAuthenticatorstate machine.cryptography >= 44.0.0requirement for Argon2 support.test_opaque.py) achieving 100% statement and branch coverage.Related PRs