Repository navigation
fix: seek no longer throws on a track without samples - #572
Merged
Merged
Conversation
Fixes gpac#515 Co-authored-by: big-nacho <67847653+big-nacho@users.noreply.github.com>
🦋 Changeset detectedLatest commit: c9dffea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #515
getTrackDurationonly checked for a missingsamplesarray, so a track whosesamplesis empty read.ctsofundefinedandseek()threw. It now returns 0 for an empty track, soseek()treats it as already ended and skips it. ReturningInfinityas in the patch in the issue would send the empty track intoseekTrack, which answers offset 0 and pulls the whole seek back to the start of the file.Added a test in
tests/segmentation.test.tsthat empties one track of01_simple.mp4and seeks to 3s; it throws before the change. Credited @big-nacho as co-author for tracking it down. Includes a patch changeset.