Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
nice one |
Contributor
|
Better fix is to simply clamp the value. The default value of Suggested fix: @Override
public int getColorForPower(byte power) {
- return RedStoneWireBlock.getColorForPower(power);
+ return RedStoneWireBlock.getColorForPower(Math.clamp(power, 0, 15));
}Repeat for fabric and forge, if they also don't clamp the value anymore. |
Owner
|
Am definitely inclined to follow Billy's solve. Both solves would technically still be a workaround instead of an actual fix since blocks are no longer stored with their default blockstate if nothing is inherently set. Long-term fix would be to cache the default blockstates and use that |
Owner
|
Superceded by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for 26.3, which no longer lists
powerforredstone_wirewhen it is at the default state, leading to the crash described in #168 (comment)