Skip to content

Fix out-of-range block index - #173

Merged
granny merged 1 commit into
granny:v3from
xu-shawn:fix/block_index_typo
Oct 12, 2026
Merged

granny merged 1 commit into
granny:v3from
xu-shawn:fix/block_index_typo

Conversation

@xu-shawn

Copy link
Copy Markdown
Contributor

Appears to be a typo. BlockInfoRenderer::scanBlock expects the index to be <2048, so this probably leads to incorrect renders.

@xu-shawn

Copy link
Copy Markdown
Contributor Author

These three indices also seems to overwrite each other? I'm not sure if that's intended.

public static final Block SULFUR_SPIKE = register(new Block(1195, "minecraft:sulfur_spike", 0xB8AB5F));
public static final Block CHISELED_SULFUR = register(new Block(1195, "minecraft:chiseled_sulfur", 0xBCAA5B));
public static final Block SULFUR_BRICK_WALL = register(new Block(1195, "minecraft:sulfur_brick_wall", 0xBBA85B));

@granny granny left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@granny
granny merged commit c33e614 into granny:v3 Oct 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants