Repository navigation
feat: link the error banner to each issue, one per click - #478
Merged
Merged
Conversation
"Scroll down to see details" is now a "Show details" link that scrolls to where an error or warning shows on the page, and then, as "Next issue" with an "n of m" count, to the next one on each click, back to the first after the last. It shows a hidden chapter first, and outlines the place it lands on for a moment. Each block marks the element that shows a reported error with data-runbook-issue (issueAnchor), and the banner visits the marked elements of the errors it counts, in page order. GitClone, GitPullRequest and DirPicker rendered nothing for a duplicate id the banner counted. They now show the duplicate id error, as the other blocks do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 23 billable files and costs up to $5.75. Or wait 20 minutes for your next included review. View limit details
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The error/warning banner's "Scroll down to see details." is now a link.
useRevealElement, now shared withuseRevealBlock).How
Each block marks the element that shows a reported error with
data-runbook-issue="<componentId>", usingissueAnchor()fromErrorReportingContext.types.ts.DuplicateIdErrormarks itself, andErrorDisplaytakes anissueId. The banner visits only the marked elements whose errors it currently counts, in DOM order.I went through every
reportError()call site so each reported error has a marker:x-show-whenerrorsFixed along the way
GitClone, GitPullRequest and DirPicker rendered
nullfor a duplicate id, so the banner counted an error that appeared nowhere on the page. They now renderDuplicateIdError, like the other blocks.Known gaps
detectCredentials/requiredRoles, and a form has none for itsx-show-whenproblems. For those, the link goes to the AzureAuth block or the form.Testing
ErrorSummaryBanner.test.tsxcovers:🤖 Generated with Claude Code