Repository navigation
fix: give template-valued inputs their declared type before rendering - #482
Draft
ZachGoldberg wants to merge 1 commit into
Draft
ZachGoldberg wants to merge 1 commit into
ZachGoldberg wants to merge 1 commit into
Conversation
A Template variable whose value is a reference such as {{ .outputs.query.AllowedLocations }}
renders to text, so a list variable arrived as the string ["eastus","eastus2"] and a template
that ranges over it failed: range can't iterate over ["eastus","eastus2"]. Ints, floats, bools
and maps had the same problem. The render path now reads each variable's type from the template's
boilerplate.yml and converts a resolved string that parses as that type.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Template variable whose value is an output reference, such as
{{ .outputs.query_existing_config.AllowedLocations }}, renders to text. So alistvariable reached the template as the string["eastus","eastus2"], and a template that ranges over it failed:int,float,boolandmapvariables had the same problem. Found running the Azure landing zoneupgrade-landing-zonerunbook, whose Generate form takes every value from an earlier step's outputs.The render path now reads each variable's declared type from the template's
boilerplate.ymland, after resolving references, converts a string that parses as that type (coerceToDeclaredTypesinflattenInputs.ts). Strings that don't parse are left for boilerplate's own validation.Not covered here: the form still shows list and number fields with an output-reference default as empty, though they render correctly now. That display bug is separate.
Tests: new unit tests in
flattenInputs.test.ts;just check, backend and integration tests pass (2 backend tests fail on this machine's Git 2.34 with or without this change).