Skip to content

fix: write the boilerplate var file as JSON so strings stay strings - #483

Draft
ZachGoldberg wants to merge 1 commit into
mainfrom
var-file-json
Draft

ZachGoldberg wants to merge 1 commit into
mainfrom
var-file-json

Conversation

@ZachGoldberg

Copy link
Copy Markdown
Collaborator

The cold render path writes --var-file with YAML.stringify, which leaves strings such as 2026-11-01T00:00:00Z, yes or 0123 unquoted. boilerplate reads the file as YAML 1.1, gets a timestamp, bool or octal number back, and rejects it for a string variable:

ERROR: Value '2026-11-01 00:00:00 +0000 UTC' is not a valid value for variable 'BudgetStartDate' with type 'string'.

Found running the Azure landing zone upgrade-landing-zone runbook, whose BudgetStartDate comes from an earlier step's output.

The var file is now JSON (valid YAML, every string quoted). Checked with the vendored boilerplate v0.17.0: the same values as plain YAML fail with the error above; as JSON they render, with lists and numbers keeping their types.

Tests: varFileContent round-trips dates, yes, 0123, lists, numbers, bools and maps through a YAML 1.1 parser; the shell-helper test now parses the var file. just check, backend and integration tests pass (2 backend tests fail on this machine's Git 2.34 with or without this change).

The cold render wrote --var-file with YAML.stringify, which leaves strings like
2026-11-01T00:00:00Z, yes or 0123 unquoted. boilerplate reads the file as YAML 1.1 and
got a timestamp, a bool or an octal number back, then rejected it for a string variable:
Value '2026-11-01 00:00:00 +0000 UTC' is not a valid value for variable 'BudgetStartDate'
with type 'string'. JSON is valid YAML and quotes every string.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
runbooks Ready Ready Preview Nov 20, 2026 11:25pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch was successfully deployed

1 active deployment
Preview — d9fd9b4c Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant