Add memory allocation check to e2e-tests global setup - #4910
Open
dominickendrick wants to merge 2 commits into
Open
dominickendrick wants to merge 2 commits into
dominickendrick wants to merge 2 commits into
Conversation
…lert the user if docker doesn't have enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a fast-failing memory check at the start of the Playwright
globalSetupfor the e2e tests.Before any Testcontainers are started,
assertSufficientMemory()comparesos.totalmem()against a required threshold (REQUIRED_MEMORY_GB = 30). If the Docker host/VM has less memory than required, it logs a clear message and callsprocess.exit(1), terminating the run immediately.Why
The full local Grid stack (Elasticsearch, LocalStack, and the eight Grid services) needs a substantial amount of memory. When Docker is under-provisioned, the stack fails to start in confusing, hard-to-diagnose ways (timeouts, OOM-killed containers). This check surfaces the real problem up front with an actionable message: increase the memory allocated to Docker.
How
os.totalmem()— cross-platform, no shell subprocess.globalSetup, so it fails before spinning up any containers.Testing
OK: ...line.Observed Error when allocation is not enough