Support for custom Gitlab URLs

[kanirudh]

My company uses a self-hosted gitlab using gitolite, I face the following error while running the plugin.

gitlab.nvim: Failure initializing plugin: invalid git URL format: gitolite@gitlab.p.ghpr.asia:gt/core/algo-services-core.git which I found comes from

gitlab.nvim/cmd/app/git/git.go

Line 65 in e29909c

return GitData{}, fmt.Errorf("invalid git URL format: %s", url)

version 3.4.0 tag v3.4.0 branch main commit e29909c

(base) ➜  algo-services-core git:(release/ASVC-80/new_context) ✗ echo $GITLAB_URL
https://gitlab.p.ghpr.asia/

(base) ➜  algo-services-core git:(release/ASVC-80/new_context) ✗ git remote get-url origin
gitolite@gitlab.p.ghpr.asia:gt/core/algo-services-core.git

I don't any configuration can bypass this setting if I am reading the go code correctly, is there a solution for this ?

[jakubbortlik]

You can try creating a hotfix by adding gitolite to the regex on this line:

diff --git a/cmd/app/git/git.go b/cmd/app/git/git.go
index 1fcc708..f743fe9 100644
--- a/cmd/app/git/git.go
+++ b/cmd/app/git/git.go
@@ -59,7 +59,7 @@ func NewGitData(remote string, gitlabUrl string, g GitManager) (GitData, error)
 	           https://git@gitlab.com/namespace/subnamespace/dummy-test-repo.git
 	           git@git@gitlab.com:namespace/subnamespace/dummy-test-repo.git
 	*/
-	re := regexp.MustCompile(`^(?:git@[^\/:]*|https?:\/\/[^\/]+|ssh:\/\/[^\/:]+)(?::\d+)?[\/:](.*)\/([^\/]+?)(?:\.git)?\/?$`)
+	re := regexp.MustCompile(`^(?:git@[^\/:]*|gitolite@[^\/:]*|https?:\/\/[^\/]+|ssh:\/\/[^\/:]+)(?::\d+)?[\/:](.*)\/([^\/]+?)(?:\.git)?\/?$`)
 	matches := re.FindStringSubmatch(url)
 	if len(matches) != 3 {
 		return GitData{}, fmt.Errorf("invalid git URL format: %s", url)

[kanirudh]

Thanks @jakubbortlik . Let me try that, assume it should work if the interfaces are the same.

[jakubbortlik]

@kanirudh have you tried the suggested solution? If it works, you can create a PR and hopefully it will be merged in.

[alsmnn]

Would it be possible to extract the ssh user from the remote url? We have a self hosted gitlab instance and the administrator changed the underlying user from git to gitlab.
So in our case the url would look like this:
gitlab@gitlab.com:namespace/subnamespace/dummy-test-repo.git
And I think it would be a pita to add every possible user name into the regex. I know it is best practice to just use the username git, but you can't rely on that, as you can see with the example of gitolite.

One thing in NewGitData() in line 60 you state, that the format should match this example:
git@git@gitlab.com:namespace/subnamespace/dummy-test-repo.git
Are you shure about the doubled git@?

Thanks for you great work, I really appreciate it and use it on daily basis!

[kanirudh]

@kanirudh have you tried the suggested solution? If it works, you can create a PR and hopefully it will be merged in.

@jakubbortlik Sorry my bad for not being on top of this, I actually made some progress with trying out the plugin locally.

Don't know your stance on AI, but asked gemini to fix this for me and it came up the following regex which is more forgiving for the initial non-capturing group.

diff --git a/cmd/app/git/git.go b/cmd/app/git/git.go
index 1fcc708..fae6151 100644
--- a/cmd/app/git/git.go
+++ b/cmd/app/git/git.go
@@ -59,7 +59,7 @@ func NewGitData(remote string, gitlabUrl string, g GitManager) (GitData, error)
                   https://git@gitlab.com/namespace/subnamespace/dummy-test-repo.git
                   git@git@gitlab.com:namespace/subnamespace/dummy-test-repo.git
        */
-       re := regexp.MustCompile(`^(?:git@[^\/:]*|https?:\/\/[^\/]+|ssh:\/\/[^\/:]+)(?::\d+)?[\/:](.*)\/([^\/]+?)(?:\.git)?\/?$`)
+       re := regexp.MustCompile(`^(?:[^\/:]+@[^\/:]*|https?:\/\/[^\/]+|ssh:\/\/[^\/:]+)(?::\d+)?[\/:](.*)\/([^\/]+?)(?:\.git)?\/?$`)
        matches := re.FindStringSubmatch(url)
        if len(matches) != 3 {
                return GitData{}, fmt.Errorf("invalid git URL format: %s", url)

[harrisoncramer]

I'm happy to accept a PR that fixes this, the Regex for these is well-tested and so it'd be a matter of configuring that to accept the new parameters. It's not something I'm able to test, but if you can get it working and add some tests I'd be happy to merge it in.