Repository navigation
fix(stat_bin): name the ngroup computed variable correctly - #1135
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 229 229
Lines 17290 17290
Branches 2203 2203
=======================================
Hits 15366 15366
Misses 1295 1295
Partials 629 629 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
has2k1
reviewed
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stat_bindocuments anngroupcomputed variable ("number of points in group", added in #462), butresult_dataframecreates the column as"ngroup:"with a stray colon. So mapping it fails:This renames the column to
ngroup, which is also the name already listed instat_bin.CREATES.Testing: added
test_histogram_ngroup, which fails on main and passes with the fix.tests/test_geom_bar_col_histogram.py,tests/test_binning.py,tests/test_stat_calculate_methods.pyandtests/test_geom_freqpoly.pypass, ruff is clean. Added a changelog entry under Bug Fixes.