Repository navigation
ci/tests: Remove Go version resolution step - #623
Merged
Merged
Conversation
SarahFrench
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has one primary objective and it is to enable the use of required checks and branch protection rulesets in GitHub which do not allow wildcards.
Sadly, GitHub does not seem interested in addressing that issue within the platform. Of course workarounds do exist but they are just that - workarounds. I think this solution feels less like a workaround.
While seeing the resolved Go versions is helpful for humans and it's sad we have to make such compromises, I think this is okay trade-off and it aligns the library with other ones we maintain.
minimalversion ingo.modI avoided adding
minimalversion to the test matrix here that I added e.g. in hashicorp/hcl#861 because the matrix itself is already quite large and tests already take quite some time to finish due to the number of Terraform versions we test against. Also today it would resolve to the same version asoldstable.E2E tests
The E2E tests suffer from the same problem and we cannot gate PRs on those. The context is just Terraform versions rather than Go versions. That's a problem for another day/PR though. Also I'm not sure we'd necessarily want to be gating PRs on E2E tests. 🤔