Skip to content

Convert horde from global $conf to HordeConfig #157

Open

Description

@ralflang

This is a low hanging fruit.

Old Pattern: global

Pattern a:

global $conf;
if (empty($conf['holidays']['enable'])) { // whatever}

Pattern b:

if (empty($GLOBALS['conf'][holidays]['enable'])) { // whatever}

New Pattern: HordeConfig

At the top of file:

use Horde\Horde\HordeConfig;

At the place where you found the pattern:
$config = $injector->get('HordeConfig');
if (empty($config->get('holidays.enable'))) { // whatever}

PRs for individual or few conversions are accepted, you don't need to submit a large bulk transformation PR.

Activity

  1. added theissue type on Sep 16, 2026
  2. ralflang commented on Sep 18, 2026

    @ralflang
    MemberAuthor

    Most are handled by #158 - The rest is probably not for beginners and demands some understanding of the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions