Skip to content

fix: correct IP allowlist toggle and Spark edge mapping - #138

Open
imbajin wants to merge 6 commits into
masterfrom
codex/fix-user-facing-import-client-20261108
Open

imbajin wants to merge 6 commits into
masterfrom
codex/fix-user-facing-import-client-20261108

Conversation

@imbajin

@imbajin imbajin commented Nov 8, 2026 •

Copy link
Copy Markdown

修改示意

toolchain138 ## 问题与修复
  • Hubble 使用的 Java Client 更新 IP 白名单开关时,将 status 放进请求体;Server 从查询参数读取该值,因此开关请求可能失败。改为把状态放在查询参数中。
  • Spark Connector 的边端点映射遇到不存在的列时会使用第 0 列;遇到重复列可能数组越界。现在在首次建立字段索引时检查字段是否恰好匹配一列,并返回明确错误,防止静默关联错误顶点。

字段校验只在索引初始化时执行,复用已有索引;没有新增逐行检查。缺失字段的任务现在会失败,之前可能继续运行并写入错误边。该改变不会回滚已经写入的数据,也不保证分区并行写入时没有部分数据。

测试与状态

  • 新增白名单开关 true / false 的本地 HTTP 请求测试。
  • 新增 Spark 字段顺序、缺失、重复、无关重复字段、重复映射字段测试,并补充通过 EdgeBuilder.build 的缺失和重复字段测试。
  • 以上测试已编写但尚未运行:当前环境无法拉取完整仓库,模块构建与真实 Server / Spark 端到端验证仍待完成。
  • 独立的 Java 探针验证了提取出的字段查找逻辑;它不是原始模块编译或端到端测试。
  • 新旧 Server 鉴权、Spark 导入写回、CI 和兼容性仍需验证。

变更基线:org master 100005cf,当前 head 8161ee93。相关扫描记录:模块扫描问题。

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8ccdf83c-8d12-4770-b4e8-a8787eb98f7c
Commits

Reviewing files that changed from the base of the PR and between 100005c and 8161ee9.

Files selected for processing: 5

  • hugegraph-client/src/main/java/org/apache/hugegraph/api/ip/WhiteIpListAPI.java
  • hugegraph-client/src/test/java/org/apache/hugegraph/unit/AuthApiPathTest.java
  • hugegraph-spark-connector/src/main/java/org/apache/hugegraph/spark/connector/builder/EdgeBuilder.java
  • hugegraph-spark-connector/src/test/java/org/apache/hugegraph/spark/connector/builder/EdgeBuilderFieldIndexesTest.java
  • hugegraph-spark-connector/src/test/java/org/apache/hugegraph/spark/connector/builder/EdgeBuilderTest.java
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@imbajin imbajin changed the title fix: correct whitelist updates and Spark edge mappings fix: 修复白名单开关和 Spark 边端点映射 Nov 8, 2026
@imbajin
imbajin marked this pull request as ready for review November 8, 2026 05:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T05:16:43.657815Z 8161ee9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.47%. Comparing base (8e6ed84) to head (8161ee9).
⚠️ Report is 79 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #138       +/-   ##
=============================================
+ Coverage     47.04%   57.47%   +10.43%     
- Complexity     4518     6526     +2008     
=============================================
  Files           602      623       +21     
  Lines         29448    33779     +4331     
  Branches       3454     4516     +1062     
=============================================
+ Hits          13854    19415     +5561     
+ Misses        14312    12649     -1663     
- Partials       1282     1715      +433     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imbajin imbajin changed the title fix: 修复白名单开关和 Spark 边端点映射 fix: correct IP allowlist toggle and Spark edge mapping Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant