Conversation
The *_FILE secrets were read at the top of the entrypoint, so they were read again after stepping down from root to the influxdb user. Root-only secret files then logged "Permission denied" and a misleading "file not existing" message on every start, even though setup had already used them. Read them only right before setup/upgrade, and log distinct warnings for missing and unreadable files.
devanbenz
requested review from
jdstrand
and
a balanced review from Copilot
September 28, 2026 18:18
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation consistently resolves the privilege-transition issue and includes targeted regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Moves secret-file reads into initialization to avoid permission errors after privilege reduction.
Changes:
- Adds deferred secret loading with distinct missing/unreadable warnings.
- Applies behavior consistently across InfluxDB 2.7–2.9 Debian and Alpine images.
- Adds an end-to-end regression test for root-only secrets.
| File | Description |
|---|---|
influxdb/2.7/entrypoint.sh |
Defers secret reads before initialization. |
influxdb/2.7/alpine/entrypoint.sh |
Applies the Alpine equivalent. |
influxdb/2.8/entrypoint.sh |
Defers secret reads before initialization. |
influxdb/2.8/alpine/entrypoint.sh |
Applies the Alpine equivalent. |
influxdb/2.9/entrypoint.sh |
Defers secret reads before initialization. |
influxdb/2.9/alpine/entrypoint.sh |
Applies the Alpine equivalent. |
influxdb/test/cases/test-auto-setup-secret-files |
Tests setup and restart with root-only secrets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes influxdata/influxdb#26673
The
DOCKER_INFLUXDB_INIT_*_FILEsecrets were read at the top ofentrypoint.sh, which runs twice: once as root, then again after stepping down toinfluxdb. With root-only secret files (e.g.0600Docker secrets), the second pass loggedPermission deniedplus a misleadingfile not existingmessage on every start, even though setup had already used the secrets.read_init_secret_files).test-auto-setup-secret-files: fails on current images, passes with this change on 2.7/2.8/2.9 (both variants).