Repository navigation
Conversation
…mes header encode_hevc_reference_frames.h guards DumpReferences() with USE_CODECHAL_DEBUG_TOOL but never included codechal_debug.h, which is the only header that defines that macro. Depending on include order, the macro could be undefined (treated as 0) in the TU that compiles encode_hevc_reference_frames.cpp while being 1 in callers that reach codechal_debug.h transitively (e.g. the new Xe3P_LPM_base HEVC vdenc packet), causing DumpReferences() to be omitted from the object file and producing an undefined symbol at link time with strict linkers (-Wl,--no-undefined). Include codechal_debug.h directly, matching the existing pattern in encode_avc_reference_frames.h, so the macro is always consistently defined for this header/TU regardless of include order. Change-Id: I3e2c3eebcb4cde47e0def137571b6e7196443e88
XinfengZhang
approved these changes
Sep 23, 2026
XinfengZhang
left a comment
XinfengZhang
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I am wondering why it was not captured by quick build @Sherry-Lin
Contributor
Author
|
@XinfengZhang can we land this as All checks have passed. Do let me know if any comments, Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encode_hevc_reference_frames.h guards DumpReferences() with USE_CODECHAL_DEBUG_TOOL but never included codechal_debug.h, which is the only header that defines that macro. Depending on include order, the macro could be undefined (treated as 0) in the TU that compiles encode_hevc_reference_frames.cpp while being 1 in callers that reach codechal_debug.h transitively (e.g. the new Xe3P_LPM_base HEVC vdenc packet), causing DumpReferences() to be omitted from the object file and producing an undefined symbol at link time with strict linkers (-Wl,--no-undefined).
Include codechal_debug.h directly, matching the existing pattern in encode_avc_reference_frames.h, so the macro is always consistently defined for this header/TU regardless of include order.
Change-Id: I3e2c3eebcb4cde47e0def137571b6e7196443e88