Repository navigation
Remove numeric_limits' Dinkumware branches - #90
Merged
Merged
Conversation
The floating-point specializations took cl's values from Dinkumware's internals (_CSTD _FInf and friends, from <ymath.h>) unless MSVC STL was at least the 2022-06 update, where they already used the builtins MSVC STL uses. That fallback can't be reached with VS 2022 or later, and the branch depended on the library (_CPPLIB_VER) rather than the compiler. cl now always uses the builtins, keyed on EA_COMPILER_MSVC; clang-cl keeps the GCC/clang branch. The values are bit-identical to before and to MSVC STL's std::numeric_limits with cl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jmgilbert2
added a commit
that referenced
this pull request
Nov 8, 2026
Brings in PRs #89 and #90: EASTL_EXCEPTIONS_ENABLED and EASTL_RTTI_ENABLED follow EABase (exceptions on unless the compiler has them off, RTTI unless it's disabled), variant's warnings that only appear with exceptions enabled are silenced, and numeric_limits loses its Dinkumware branches. Master's test changes don't apply to this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last Dinkumware-era code in EASTL: the floating-point
numeric_limitsbranch for cl.Before
For cl,
numeric_limits<float>,<double>and<long double>took their special values from Dinkumware's internals (_CSTD _FInf,_Nan,_Snan,_Denormand friends, from<ymath.h>), unless MSVC STL was at least its 2022-06 update. From that update on, they already used the same builtins as MSVC STL. Two problems:_CPPLIB_VER), not the compiler.After
__builtin_huge_val*,__builtin_nan*("0"),__builtin_nans*("1"),*_TRUE_MIN), keyed onEA_COMPILER_MSVC.<ymath.h>and the_CPPLIB_VER/_MSVC_STL_UPDATEchecks are gone.Verification
min,max,lowest,epsilon,round_error,infinity,quiet_NaN,signaling_NaNanddenorm_minof all three types, with cl and clang-cl. With cl they also match MSVC STL'sstd::numeric_limitsexactly. With clang-cl, onlysignaling_NaN's payload differs from MSVC STL's, as on master:__builtin_nansf("")vs("1"), both valid signaling NaNs.🤖 Generated with Claude Code