Repository navigation
MNT Use Ruff and pre-commit for linting - #686
Open
Swapnil-byte-798 wants to merge 2 commits into
Open
Swapnil-byte-798 wants to merge 2 commits into
Swapnil-byte-798 wants to merge 2 commits into
Conversation
Use the same pre-commit configuration locally and in the locked Pixi lint task. Preserve the formatting width and skip vendored CPython source. Co-authored-by: Codex <codex@openai.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Keep the Unix virtual-package entries in the form written by Pixi 0.82.0. Co-authored-by: Codex <codex@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684. Follows the Ruff and pre-commit setup in joblib/threadpoolctl#258 and joblib/threadpoolctl#269.
The locked Pixi lint task runs the same pre-commit checks available locally. Ruff checks Python errors and formats at the existing 79-character width. The vendored CPython resource tracker stays excluded from Ruff, including when pre-commit passes it by filename.
The lockfile changes are confined to the lint environment. The formatting and lint cleanup preserve the resource lifetimes in the backend tests.
Validation
pixi run --locked lintpassed all nine hooks.git diff --checkpassed and the vendored resource tracker is byte-identical.Codex assisted with the implementation and local validation.