Conversation
Accepting all incoming changes, re-apply ruff format
tromai
marked this pull request as ready for review
September 14, 2026 04:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on top of #142. Merging #142 will simplify the changes here.
Changes relevant to this PR starts from 0dfaec4
This PR made various improvements to the repo CI setup.
1. Add codespell
This tool is run in
run_testsscript. There is no error reported by the tool.2. Updates how ops is imported in
charm.pyandtest_charm.pyUse
import opsthenops.Foo.Bar(...)instead offrom ops.Foo import Bar. This is Charm Tech recommended style.There is no runtime behaviour change.
3. Pin all action to commit hashes of latest version.
I also set the Juju channel to
4.1/stableas we discussed. We expect the CI to break until that channel is available.4. Update
opsversion, and run CI with versions from uv.lockWe use different
opsversions between packing and running unit tests:uv pip install ".[dev]"doesn't respect the locked version. Therefore it fetches the latest version sinceopsis not pinned inpyproject.toml.We want it to be consistent.
Solution:
opsversion to~=3.8which is3.8or any newer3.xversion.uv.lockto use thisopsversion.uv sync --frozen --extra devto prepare the virtual environment in respect touv.lock(updates inci.yaml,CONTRIBUTING.md, andAGENTS.md).