Skip to content

docs: remove apiExportName from helm values - #187

Open
mstruebing wants to merge 1 commit into
kcp-dev:mainfrom
mstruebing:docs-helm
Open

docs: remove apiExportName from helm values#187
mstruebing wants to merge 1 commit into
kcp-dev:mainfrom
mstruebing:docs-helm

Conversation

@mstruebing

@mstruebing mstruebing commented Sep 8, 2026

Copy link
Copy Markdown

Summary

I tried to follow the docs to get to a working sync agent and figured out this option is not supported anymore

What Type of PR Is This?

/kind documentation

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Sep 8, 2026
@kcp-ci-bot

kcp-ci-bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Hi @mstruebing. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2026
@mstruebing
docs: remove apiExportName from helm values
763e334 
I tried to follow the docs to get to a working sync agent and figured out
this option is not supported anymore

Signed-off-by: Max Struebing <mxstrbng@gmail.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Sep 8, 2026
mjudeikis
mjudeikis approved these changes Sep 11, 2026
View reviewed changes

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2026
@kcp-ci-bot

kcp-ci-bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 3c210f106808f280539b95fa5e19b88fc9750ec4

@kcp-ci-bot

kcp-ci-bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjudeikis
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstruebing

mstruebing commented Sep 11, 2026

Copy link
Copy Markdown
Author

/assign @embik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

Assignees

@mjudeikis mjudeikis

@embik embik

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mstruebing @kcp-ci-bot @mjudeikis @embik