Skip to content
This repository was archived by the owner on Oct 29, 2022. It is now read-only.
This repository was archived by the owner on Oct 29, 2022. It is now read-only.

Run pre-commit in GitHub Actions #61

Open
Open
Run pre-commit in GitHub Actions#61
Assignees
jonafato
Labels
adminautomationenhancementNew feature or requestgh action

Description

@jonafato
jonafato
opened on Sep 1, 2022

As a followup to #52, we should run these tasks in GitHub Actions. Generally speaking,

  • Autoformatters should commit changes back to pull requests
  • Linters, etc. should fail with an error like any other test step

Activity

  1. jonafato
    self-assigned this
    on Sep 1, 2022

  2. kjaymiller commented on Sep 2, 2022

    @kjaymiller
    kjaymiller
    on Sep 2, 2022
    Owner

    Not sure this is possible (or at least will be supported long term) - https://github.com/pre-commit/action has been deprecated in favor of running their own CI

  3. jonafato commented on Sep 2, 2022

    @jonafato
    jonafato
    on Sep 2, 2022
    CollaboratorAuthor

    It's possible, I've done it on tons of repositories. We don't need the official action for it. Self-assigned, so I'll follow up with a PR.

  4. jonafato commented on Sep 3, 2022

    @jonafato
    jonafato
    on Sep 3, 2022
    CollaboratorAuthor

    This is half-addressed by #77. Autoformatters committing back to be addressed in another change.

  5. kjaymiller
    added
    gh action
    automation
    enhancementNew feature or request
    admin
    on Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

adminautomationenhancementNew feature or requestgh action

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions