Repository navigation
Remove the additional explicit wait "hack" in progress bar #1965
Description
Activity
I don't think it is possible with the current API. When the
tea.Quitcommand is handled, the Bubbletea's renderer stops, and restores the terminal to standard output mode. So, you can't replace the line that was already written.I think the Bubbletea should allow defining the last
tea.Quitstate, that will be printed just before the exit, and without waiting for the animation loop to draw it./kind bug
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with/reopen. Mark the issue as
fresh by adding the comment/remove-lifecycle stale./remove-lifecycle stale
The additional explicit wait "hack" in the progress bar should be removed. If your UI has a lot of progress bars, this wait will be visible.
https://github.com/knative/client-pkg/blob/cf1573f9363107e30399011565bf11f95bac52d7/pkg/output/tui/progress.go#L188-L193
But, I don't see a way, with the current API of bubbles' progress, to achieve it otherwise...
Without the wait, we get UI with progress bars that are never 100% completed. See example: knative/client-pkg#162 (comment)
Originally posted by @cardil in knative/client-pkg#162 (comment)