Repository navigation
Conversation
The Server registers a subscriber only after it flushes the response headers, so Subscribe can return before events are deliverable. The publisher's five 1ms ticks could all reach nobody, leaving the example waiting forever; Windows CI hit this and timed out after 10m. Start publishing once a Repository's Replay call shows the subscriber is registered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExampleEventhangs until the 10m test timeout on Windows CI. It hitmainin run 32182612530 (both Windows jobs), and #78 in run 35921918139.Subscribecan therefore return, and the publisher can send all five 1ms ticks, before the subscriber is registered. Every tick then reaches nobody, and the example waits onstream.Eventsforever.Repositorythat replays nothing and setReplayAll. The Server callsReplayonly after it adds the subscriber, so the example starts publishing only after that call.ExampleRepositorypublishes right afterSubscribein the same way. It hasn't failed in CI, and this PR leaves it alone.🤖 Generated with Claude Code