Repository navigation
chore: Update Gradle wrapper to 9.5.1 - #38
Closed
kinyoklion wants to merge 1 commit into
Closed
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Member
Author
|
Closing in favor of doing this while migrating to java-core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces dependabot's #35, which only bumped the wrapper files. It failed for two reasons: Gradle 9 needs Java 17+ to run, and the build used APIs that Gradle 9 removed.
Gradle 9 needs Java 17 to run, but the library still targets Java 8
compileJavanow usesoptions.release = 8, so the compiler checks against the Java 8 API and emits class version 52..github/actions/ci) installs both the matrix JDK and JDK 17. Gradle runs on 17, and the tests run on the matrix JDK through a toolchain:-PtestJavaVersion, the tests run on the JVM that runs Gradle..ldreleaseimage changes fromgradle:7.6-jdk8togradle:9.5.1-jdk17.Build script changes for Gradle 9
archivesBaseName/sourceCompatibilityset as project conventions →base { archivesName }/java { }.sourcesJar/javadocJartasks usedclassifier, which was removed. They are replaced byjava { withSourcesJar(); withJavadocJar() }.de.marcphilipp.nexus-publish0.4.0 andio.codearte.nexus-staging0.30.0 fail on Gradle 9 (org/gradle/util/ConfigureUtilwas removed). Both are replaced byio.github.gradle-nexus.publish-plugin2.0.0, set up with the same Central Portal OSSRH-staging URLs that java-core uses. TheossrhUsername/ossrhPasswordcredentials stay the same.maven { url "..." }→url = "..."(deprecated in 9.x, removed in 10).Checked locally
jar javadoc checkstyleMain publishToMavenLocalpasses with--warning-mode alland no deprecation warnings./usr/lib/jvm/java-{8,11}-openjdk-amd64/bin/java.main:.modulefile gainsjavadocElements/sourcesElementsvariants, which is whatwithJavadocJar/withSourcesJaradd.gradle:9.5.1-jdk17image, the build andpublishToMavenLocalpass, and thepublishToSonatypeandcloseAndReleaseSonatypeStagingRepositorytasks are present.Reviewer notes
closeAndReleaseRepository→closeAndReleaseSonatypeStagingRepository). I can't see which tasks the Releasergradletemplate runs, so please confirm the release path. Releases from this repo were already pointed at the retiredoss.sonatype.orgOSSRH host.Link to Devin session: https://app.devin.ai/sessions/1a79310b63c847508c621a56ea406e4c
Open in Devin Desktop: https://app.devin.ai/desktop/session/1a79310b63c847508c621a56ea406e4c?variant=devin
Requested by: @kinyoklion