Repository navigation
BOLT 2: add receiver requirement for announced scid_alias channels - #1359
Open
NishantBansal2003 wants to merge 1 commit into
Open
NishantBansal2003 wants to merge 1 commit into
NishantBansal2003 wants to merge 1 commit into
Conversation
The sender of `open_channel` must not set `option_scid_alias` in `channel_type` when `announce_channel` is set, but the receiver had no matching requirement. Such a channel presents its real `short_channel_id` in the `channel_announcement`, yet rejects incoming HTLCs using it, so payments routed through it using gossip always fail. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
14 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sender of
open_channelmust not setoption_scid_aliasinchannel_typewhenannounce_channelis set, but the receiver had no matching requirement.Such a channel presents its real
short_channel_idin thechannel_announcement, yet rejects incoming HTLCs using it, so payments routed through it using gossip always fail.