TPT-4659: Add NFS Quotas - #1050
Merged
yec-akamai merged 7 commits intoSep 29, 2026
Merged
Conversation
AshleyDumaine
requested review from
lgarber-akamai and
mawilk90
and removed request for
a team
September 24, 2026 16:00
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Handle terminal error status immediately and add polling-helper test coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds Linodego v4beta support for NFS quota CRUD operations, capacity and usage fields, fixtures, tests, and lifecycle polling.
Changes:
- Added NFS quota models and CRUD clients.
- Added quota status polling support.
- Added unit tests and JSON fixtures.
| File | Summary |
|---|---|
waitfor.go |
NFS quota lifecycle polling |
test/unit/nfs_quotas_test.go |
CRUD and parsing tests |
test/unit/fixtures/nfs_quotas_list.json |
List-quota fixture |
test/unit/fixtures/nfs_quota.json |
Single-quota fixture |
nfs_quotas.go |
NFS quota models and CRUD clients |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+301
to
+308
| return poll(ctx, &client, | ||
| func(ctx context.Context) (*NFSQuota, bool, error) { | ||
| quota, err := client.GetNFSQuota(ctx, spaceID, filesystemID, quotaID) | ||
| if err != nil { | ||
| return quota, false, err | ||
| } | ||
|
|
||
| return quota, quota.Status == status, nil |
lgarber-akamai
approved these changes
Sep 28, 2026
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the contribution!
mawilk90
approved these changes
Sep 29, 2026
yec-akamai
reviewed
Sep 29, 2026
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the work! Just a nitpick:
yec-akamai
reviewed
Sep 29, 2026
yec-akamai
reviewed
Sep 29, 2026
yec-akamai
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds Linodego v4beta client support for NFS Quota CRUD clients, capacity and usage fields, and lifecycle wait helpers.
These endpoints are needed by the Linode File Storage CSI driver.
Live integration and fixture testing are unavailable because the NFS APIs are not in production. Both commits pass make build and temporary HTTP client smoke checks.