Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3934a3d to
04bbde6
Compare
5838074 to
b1eadef
Compare
|
Superseded by #231 (Contracts, verification infrastructure and resource limits) in the consolidated eight-PR stack for #162. The replacement preserves this PR's code and subsequent fixes; its description links the original head and review discussions. The only additional consolidation fix is the CI-discovered listener cancellation regression, documented on the replacement. All eight replacements have passed their required CI checks. Closing without merging. This branch and its discussions remain available for reference. Review index: #162 (comment) |
Active piece transfers could exhaust the shared buffer budget and prevent a magnet metadata request from obtaining its scratch reservation. Give transfers and metadata independent partitions under a combined exchange ceiling, so a full transfer partition still permits one metadata exchange.
Stack: based on #164 (
torrent-v2-01-contracts), following #163. This is the exchange-budget slice of roadmap #162 step 01.Reservations account against both child and parent budgets, roll back on failed admission, and release only once. Configuration rejects insufficient headroom using overflow-safe arithmetic. The existing metadata wire tests now run with the entire transfer partition reserved; a canceled handshake must release metadata reservations while preserving the transfer reservation.
Validation: full torrent JVM conformance and native runtime dependency guard pass with both pinned clients. Focused tests cover aggregate exhaustion, rollback, double-close, integer overflow, reordered/corrupt/oversized/private metadata, and cancellation cleanup.
maxExchangeBytesbounds exchange buffers only. Retained metadata, session indexes, OS allocations, production profiles, and performance/soak gates remain pending; this PR makes no total-memory or RSS claim.