Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Superseded by #235 (V2 handshake, hash exchange and bounded transport) in the consolidated eight-PR stack for #162. The replacement preserves this PR's code and subsequent fixes; its description links the original head and review discussions. The only additional consolidation fix is the CI-discovered listener cancellation regression, documented on the replacement. All eight replacements have passed their required CI checks. Closing without merging. This branch and its discussions remain available for reference. Review index: #162 (comment) |
Tracks hash requests under a connection owner and reserves shared exchange credit before issuing them. Responses must match an outstanding selector, meet its deadline and authenticate against the trusted file root before delivery. Successful results retain their reservation until the consumer closes them; rejection, invalid proof, expiry, cancellation and connection close release pending credit. Local ticket identity prevents stale cancellation callbacks from releasing replacement requests.
Stacked on #187; advances step 08 of #162. Root lookup must use authenticated metainfo, and callers must serialize operations on the connection event loop. Live routing/timers, reader admission for unsolicited frames, cache ownership and serving remain pending. A delayed wire reply for identical immutable coordinates may satisfy a new request only after proof verification; the wire protocol has no separate transaction ID.
Validation: all 407 JVM torrent tests pass with zero failures/errors/skips, including four new exchange ownership/admission tests, exact wire/proof tests and both pinned-client v1 conformance scenarios. The native-runtime guard and iOS test-source compilation pass. This slice does not claim executed v2 network interoperability or complete production resource gates.