Skip to content

Fix pre-existing legacy 502 - prod - #5247

Merged
lukaszgryglicki merged 2 commits into
mainfrom
unicron-fix-502-auto-ccla-prod
Oct 8, 2026
Merged

lukaszgryglicki merged 2 commits into
mainfrom
unicron-fix-502-auto-ccla-prod

Conversation

@lukaszgryglicki

Copy link
Copy Markdown
Member

cc @mlehotskylf @ahmedomosanya

Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Assisted by Claude

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)

Assisted by [Claude](https://claude.ai)
@lukaszgryglicki lukaszgryglicki self-assigned this Oct 8, 2026
Copilot AI balanced review requested due to automatic review settings October 8, 2026 07:24
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 49611294-0559-485f-a033-c8ca0acf90a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused nil guard matches the repository contract and is covered by a regression test.

0 open findings

What changed in this PR

Prevents a missing signed CCLA from causing a production 502 in the v4 ECLA auto-create flow.

Changes:

  • Returns HTTP 404 when no matching CCLA exists.
  • Adds regression coverage for the nil-signature case.
  • Adds a production ACS role-management helper.
File Description
utils/​prod_acs_role_flip.sh Adds the production operations helper.
cla-backend-go/​v2/​signatures/​handlers.go Handles missing CCLAs safely.
cla-backend-go/​v2/​signatures/​handlers_sanctions_test.go Verifies the 404 response.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@mlehotskylf mlehotskylf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same diff as #5246, so the same feedback applies: the handler fix is good, but please drop utils/prod_acs_role_flip.sh before approval. Details: #5246 (review)

@lukaszgryglicki

Copy link
Copy Markdown
Member Author

Same as #5246: the local-only util script stays in this PR (see replies there) - please re-review.

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)

Assisted by [Claude](https://claude.ai)
Copilot AI balanced review requested due to automatic review settings October 8, 2026 08:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The guard matches the repository lookup contract and API specification, has targeted regression coverage, and the new script passes syntax validation.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@lukaszgryglicki
lukaszgryglicki merged commit 391963a into main Oct 8, 2026
8 checks passed
@lukaszgryglicki
lukaszgryglicki deleted the unicron-fix-502-auto-ccla-prod branch October 8, 2026 08:17

This branch was successfully deployed

1 active deployment
dev — 300766b2 Deployed Oct 8, 2026 by lukaszgryglicki via License Header Check #1422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants