Repository navigation
Fix pre-existing legacy 502 - prod - #5247
Conversation
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot) Assisted by [Claude](https://claude.ai)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The focused nil guard matches the repository contract and is covered by a regression test.
0 open findings
What changed in this PR
Prevents a missing signed CCLA from causing a production 502 in the v4 ECLA auto-create flow.
Changes:
- Returns HTTP 404 when no matching CCLA exists.
- Adds regression coverage for the nil-signature case.
- Adds a production ACS role-management helper.
| File | Description |
|---|---|
utils/prod_acs_role_flip.sh |
Adds the production operations helper. |
cla-backend-go/v2/signatures/handlers.go |
Handles missing CCLAs safely. |
cla-backend-go/v2/signatures/handlers_sanctions_test.go |
Verifies the 404 response. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
mlehotskylf
left a comment
There was a problem hiding this comment.
This has the same diff as #5246, so the same feedback applies: the handler fix is good, but please drop utils/prod_acs_role_flip.sh before approval. Details: #5246 (review)
|
Same as #5246: the local-only util script stays in this PR (see replies there) - please re-review. |
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot) Assisted by [Claude](https://claude.ai)
There was a problem hiding this comment.
🟢 Approval recommended
The guard matches the repository lookup contract and API specification, has targeted regression coverage, and the new script passes syntax validation.
0 open findings
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
cc @mlehotskylf @ahmedomosanya
Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot
Assisted by Claude