Repository navigation
chore(utils): add flush-cache to dev_acs_role_flip.sh - #5259
Merged
Merged
Conversation
ACS caches GET /warden/subjects/authorize for 30 minutes, keyed by URL and username. user-service /v1/me/permissions reads it, so a cla-manager grant or revoke made with this script takes up to 30 minutes to reach Self Serve. The per-user /cache/reset does not reach that entry, so a role change never clears it. flush-cache calls ACS POST /cache/flush with the script's existing dev M2M token. It empties the whole ACS cache for every dev user, so the next read sees current roles. Signed-off-by: ahmedomosanya <aopeyemi@contractor.linuxfoundation.org>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The script passes shell syntax validation and introduces no exposed secrets.
0 open findings
What changed in this PR
Adds a dev-only ACS cache flush command so role changes reach Self Serve promptly.
Changes:
- Adds
flush-cacheusing the existing M2M token. - Documents cache behavior and command usage.
| File | Description |
|---|---|
utils/dev_acs_role_flip.sh |
Adds and documents ACS cache flushing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACS caches
GET /warden/subjects/authorizefor 30 minutes, keyed by URL and username. user-service/v1/me/permissionsreads it, so acla-managergrant or revoke made with this script takes up to 30 minutes to reach Self Serve. A role change does not clear the entry, and ACS's per-user/cache/resetdoes not reach it either.flush-cachecalls ACSPOST /cache/flushwith the script's existing dev M2M token. It empties the whole ACS cache for every dev user, so the next read sees current roles. Dev only, like the rest of the script.Tested in dev: a grant followed by
flush-cacheshowed up in Self Serve on the next page load instead of after 30 minutes.