Repository navigation
get_flashzoi_checkpoint: cache key includes revision; clearer error without torch - #14
Merged
Merged
Conversation
…orch
- The renamed checkpoint is cached as fold_{fold}.{revision[:12]}.renamed.pt,
so re-pinning a fold in REVISIONS no longer reuses the old weights.
- A missing torch or huggingface_hub raises FileNotAvailableError with an
install hint instead of a bare ModuleNotFoundError.
- metadata.get_chromvar_score_path takes allow_download, like
get_flashzoi_checkpoint and get_gtf_path.
Closes #12
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12
Evidence
torch/huggingface_hubraisedModuleNotFoundErrorget_chromvar_score_path(allow_download=False)raisedTypeErrorpytest: 31 passed, 1 skipped (needs lab data);ruff checkclean.Merge Danger
Door: two-way
Blast Radius: cache
Existing users download each Flashzoi fold once more; the old
fold_N.renamed.ptfiles stay in their cache unused. Lab-filesystem users are unaffected (the lab checkpoint path is unchanged).🤖 Generated with Claude Code