Repository navigation
feat(acme): settle the advance in Xero (lands #8 on main) - #9
Merged
Merged
Conversation
The seeder gave the merchant's first bank account the token btok_us, which Stripe does not have. The old Stripe app emulator accepted any token, but the current one refuses a token it does not know, and seeding failed with No such token. Use btok_us_verified, one of Stripe's own test tokens, which both builds accept.
Funding moves the money, and the merchant's books have to show it. The advance is booked as money received against a new loan liability account, which debits the bank and credits the loan, so it needs no manual journal. The account and the lender contact are created only if missing, and the bank transaction is found by its reference before it is recorded, so a retry never books the advance twice.
The UI's second click now runs accept, fund and settle.
The second click now accepts the offer, pays the advance out and records it in the merchant's Xero books. The funding card shows where it was booked: the bank account it was received into, the loan account and the bank transaction. A failed settlement retries on its own, without paying the advance out again.
Say how the advance is booked, why it needs no manual journal, that every step checks before it creates so a retry or a second application duplicates nothing, and which Xero app emulator builds can do it.
feat: record the advance in the merchant's Xero books
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
localstack-samples/localstack-app-emulators#8was merged intofeat/ui-v1, which#7had already merged intomain. The settlement commits never reachedmain. This PR carries them there.Changes
btok_us_verified).These are the commits of
#8, unchanged, plus its merge commit.Tests
The same commits passed
build-and-testandwebonlocalstack-samples/localstack-app-emulators#8. CI on this PR runs the same jobs againstmain.Related
localstack-samples/localstack-app-emulators#8,localstack-samples/localstack-app-emulators#7. Merge with a merge commit, not a squash.