Skip to content

Let a flow config name the coverage sources its vPlan annotation reads #251

Description

@martin-velay

Part of lowRISC/dvplan#129, which tracks formal support end to end.

report/vplan.py builds the annotation command with one vendor coverage report and one evidence file, and it derives the format name from the simulator. A formal run has its own report in its own format, and a config bundling a simulation run with a formal run has several. So the flow config should say what its sources are, and the command builder should splat them.

Scope

  • A vplan_sources() method on FlowCfg returning the coverage sources this config produced, each as a format name and one or more paths. The default is empty.
  • SimCfg returns its vendor coverage report directory when coverage ran, plus the evidence file. Same two sources as today, same order, so the command it produces is unchanged.
  • VPlanInputs takes the list, and _process_command stops naming cov_report_dir and tool itself.
  • Replace the f"{inputs.tool}_report" concatenation with an explicit map from tool to format name. Right now the coupling to DVPlan's format names is invisible, and it is about to grow two formal entries whose tool names differ from the simulator ones.

Done when

  • The generated command for a simulation config is byte for byte what it is today, pinned by the existing tests in tests/report/test_vplan.py and tests/job/test_cov_vplan.py.
  • An unknown tool name gives a clear error naming the tools that map to a format, which is the same complaint as Give a better error message on a silly --tool value #233.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions