You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Part of lowRISC/dvplan#129, which tracks formal support end to end.
report/vplan.py builds the annotation command with one vendor coverage report and one evidence file, and it derives the format name from the simulator. A formal run has its own report in its own format, and a config bundling a simulation run with a formal run has several. So the flow config should say what its sources are, and the command builder should splat them.
Scope
A vplan_sources() method on FlowCfg returning the coverage sources this config produced, each as a format name and one or more paths. The default is empty.
SimCfg returns its vendor coverage report directory when coverage ran, plus the evidence file. Same two sources as today, same order, so the command it produces is unchanged.
VPlanInputs takes the list, and _process_command stops naming cov_report_dir and tool itself.
Replace the f"{inputs.tool}_report" concatenation with an explicit map from tool to format name. Right now the coupling to DVPlan's format names is invisible, and it is about to grow two formal entries whose tool names differ from the simulator ones.
Done when
The generated command for a simulation config is byte for byte what it is today, pinned by the existing tests in tests/report/test_vplan.py and tests/job/test_cov_vplan.py.
Part of lowRISC/dvplan#129, which tracks formal support end to end.
report/vplan.pybuilds the annotation command with one vendor coverage report and one evidence file, and it derives the format name from the simulator. A formal run has its own report in its own format, and a config bundling a simulation run with a formal run has several. So the flow config should say what its sources are, and the command builder should splat them.Scope
vplan_sources()method onFlowCfgreturning the coverage sources this config produced, each as a format name and one or more paths. The default is empty.SimCfgreturns its vendor coverage report directory when coverage ran, plus the evidence file. Same two sources as today, same order, so the command it produces is unchanged.VPlanInputstakes the list, and_process_commandstops namingcov_report_dirandtoolitself.f"{inputs.tool}_report"concatenation with an explicit map from tool to format name. Right now the coupling to DVPlan's format names is invisible, and it is about to grow two formal entries whose tool names differ from the simulator ones.Done when
tests/report/test_vplan.pyandtests/job/test_cov_vplan.py.