SP-3082: NBs 103-series image mosaic & custom color - #214
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MelissaGraham
self-requested a review
September 16, 2026 21:55
MelissaGraham
approved these changes
Sep 16, 2026
MelissaGraham
left a comment
MelissaGraham
left a comment
Contributor
There was a problem hiding this comment.
103 8
- butler asserts no longer needed (and in 103 9)
- if 0.05 is the half size then 0.1 deg would be full but text says 0.2
- add narrative to S.4 and S.4.1, even if just a sentence before each code cell
- add a figure showing what the Firefly display should be like, so users can confirm it worked right
- S.5. need to clarify whether the point is that the PSFs are the same or different (i.e., was 0.37% expected/small, or is this concerning/big) for the same coordinates; I'd have assumed no difference since it should be the exact same pixels, but is the point that this is the affect of warping to a new WCS?
Fix error in color image pretty coadd approx Update
Test parameters
plazas
force-pushed
the
tickets/SP-3082
branch
from
September 20, 2026 02:25
f8f21ca to
6c2e072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.