Repository navigation
docs(changelog): list the Azure path fix under Python SDK 1.0.0 - #628
Conversation
The sdk-python/v0.6.0 tag predates #623, so the fix first shipped in 1.0.0, not in 0.6.0 as the changelog said.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Release entry placement docs/changelogs/sdk-python.md |
The 1.0.0 Fixed section adds the entry describing reference normalization. The 0.6.0 Fixed section removes the entry. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Possibly related PRs
- macalbert/envilder#623: Implements the Azure Key Vault rule described by this changelog entry.
- macalbert/envilder#612: Documents the prior .NET SDK behavior for Azure Key Vault secret names.
Merge Risk: 
Minimal · up to 3aaed
-
The changelog correction does not affect runtime or deployment behavior.
Pre-merge checks: 
7
-
Full details: Title check
-
Explanation
The title follows Conventional Commits: type is docs, scope is changelog, and the subject is lowercase. It is 63 characters, under the 100-character limit. It names the Azure path fix and the Python SDK 1.0.0 section, which matches the changeset that moves the entry from 0.6.0 to 1.0.0.
Full details: Description check
-
Explanation
The description follows the repository template. It has a clear summary of why the entry moves, a changes list, and a testing section. It also links related issues
#623and#624. The template's 'What does this PR do?', 'Related issues', 'Type of change', and 'Checklist' headings are reworded or missing. The 'Type of change' checkbox is not ticked, and 'Notes for reviewer' is absent. These are minor gaps, so the description is mostly complete.
Full details: Architecture Boundaries
-
Explanation
The pull request changes only
docs/changelogs/sdk-python.md. No changed file is undersrc/envilder/core/domain/orsrc/envilder/core/application/, so the specified import-boundary conditions do not apply.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
The Python SDK changelog listed the Azure Key Vault
/fix (#623) under 0.6.0, but thesdk-python/v0.6.0tag points to #624, which predates #623, so 0.6.0 on PyPI does not include it. The fix first shipped in 1.0.0, so the entry moves there.Changes
/resolve the same secret as the CLI" entry from[0.6.0]to[1.0.0]under### Fixedindocs/changelogs/sdk-python.mdTesting
pnpm testpasses (N/A: documentation only)pnpm lintpasses (N/A: documentation only)git merge-base --is-ancestor 876bd8fd sdk-python/v0.6.0fails and succeeds forsdk-python/v1.0.0Related
#623, #624
Summary by CodeRabbit
/with-and ignore leading slashes; other values are sent unchanged.