Updated ffv parser from PDF to default - #7225
Draft
nicolaibvm wants to merge 1 commit into
Draft
Conversation
After having FFV adding next schedule to affaldonline, I found that PDF is not the right parser, but comparing to the output of assens it should be default. My tests with the regex seems to correspond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After having FFV adding next schedule to affaldonline, I found that PDF is not the right parser, but comparing to the output of assens it should be default. My tests with the regex seems to correspond.
I think I have done this incorrectly. I am not used to doing this. I made a commit (push/pull?) of this code earlier. It didn't work. Therefore I have worked on getting the info on the homepage. The data is now there but I cannot remember how I committed the last time. If this is totally wrong, please delete this. I can't seem to do it myself. I apologize for any inconvenience.
I also guess that if this is accepted, that the doc/source/affaldonline_dk.md, should be updated to reflect the changes. I will of course do this and try to do it the right way, this time.
Type of change
Checklist
python -m pytest tests/test_source_components.py -qpassesruff check --fixandruff formatrun on changed source filesdoc/source/<name>.mdcreated for new sources