Repository navigation
fix(ios): stabilize podspec checksum - #72
Open
huytdps13400 wants to merge 1 commit into
Open
huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PODS_TARGET_SRCROOTnode_moduleslayouts for the framework copy stepFixes #58.
Root cause
The podspec built
skiaPathwith__dir__, so CocoaPods serialized the consumer's absolute checkout path into bothHEADER_SEARCH_PATHSandprepare_command. Because the podspec JSON changed for every project location, its checksum changed as well.The podspec still detects whether Skia is nested or hoisted, but now stores only the relative segment. Xcode receives a target-root-relative header path, while
prepare_commandcontinues to run from the pod source root.Verification
pod ipc specthrough two paths to the same source produced different SHA-256 values (4bf472…vs641272…).1d8cf3…)./tmpor absolute source path.prepare_commandsuccessfully with both nested and hoisted React Native Skia layouts; both xcframeworks were copied.pod installcompleted successfully for the repository example (61pods installed, includingreact-native-skia-skottie 2.1.4).yarn test --runInBandyarn typecheckyarn lintyarn prepack && yarn postpackruby -c react-native-skia-skottie.podspecgit diff --checkOnly the podspec is committed; generated Pods, build output, and lockfile changes are excluded.