Repository navigation
fix(runtime-tags): link a <define> scope that only its calls read through - #4497
Merged
DylanPiercey merged 1 commit intoOct 22, 2026
Conversation
…hrough A `<define>` call links its body's scope to the body's owner through the calling scopes, but only reads of the calling body's own closures marked it as reading its owner. A body that only called another `<define>`, whose body read the template's values, never got its own owner link, so the inner call copied `undefined` and the client render threw. A body that reads its owner now marks each of its calls' scopes up to its owner, and those links resume when the client can create the calling scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4497 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 419 419
Lines 20853 20860 +7
Branches 4158 4160 +2
=======================================
+ Hits 19778 19785 +7
Misses 617 617
Partials 458 458 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<define>that renders another<define>(<define/E>…</define><define/D><E/></define><D/>) threw on client render and on a later resume: E's owner link reads D's own owner, but D's body reads nothing of its owner itself, so D's link was never emitted and E's closure subscription foundundefined.The link from a call to its body's owner is an owner read across the call's section chain, so a body that reads its owner now marks its call sections the same way closures and refs already do, and a solve rule writes that link on resume only where the client can create the inner call. Existing output and the floors are unchanged.
🤖 Generated with Claude Code