Repository navigation
Conversation
HedwigAR
force-pushed
the
AT-239/tooltip-accessibility-improvement-screenreader
branch
from
April 24, 2026 09:24
f727c6f to
1d9f4e3
Compare
yordan-st
force-pushed
the
AT-239/tooltip-accessibility-improvement-screenreader
branch
from
November 2, 2026 15:50
0a73e2d to
14f6b5a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Keep one content element in the DOM, hidden and inert while closed, so custom content is not duplicated. Merge the tooltip id into existing aria-describedby values and watch the trigger for late-mounted elements and attribute resets.
yordan-st
force-pushed
the
AT-239/tooltip-accessibility-improvement-screenreader
branch
from
November 4, 2026 10:45
e333f0a to
77324f9
Compare
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): none. CI: pending: Plan E2E matrix, Run code quality check, sigridci · unrelated failures: security/snyk (external scanner, not tied to this diff) Questions
Positives
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Screen reader users who tab to an interactive tooltip trigger hear nothing, because tooltip content is only in the DOM while open, and the
aria-describedbyfrom Floating UI sits on the non-focusable trigger wrapper (WC-3404).This PR:
inertwhile closed, and shown as the tooltip while open.aria-describedbyon focusable trigger elements, keeping existing values.MutationObserverto cover late-mounted elements and attribute resets.aria-describedbyhandling in the Studio Pro preview.I took over this PR from the original author. Since their last update, I rebased it on
main, addressed the AI review comments, replaced the single hidden copy approach with one content element, and replacedAGENTS.mdwith OpenSpec changes inopenspec/changes/.Behavior change to review: custom content widgets now mount at page load instead of on first open, because a description needs content in the DOM. Data widgets inside a tooltip load earlier as a result.
Out of scope: default Hover mode still does not open on keyboard focus, which differs from the Deque tooltip pattern. This needs a separate ticket.
What should be covered while testing?
Unit tests and lint pass locally. Manual QA:
Open onmodes