You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems the condition that triggers hand off between preallocated parameter conversions and ad hoc conversions may be off by one. If I change i < maxLookup to i < maxLookup - 1 everything works fine but not sure if that's right, as the last element in equalsPlaceholderTab will not be used. Also, is it right that equalsPlaceholderTab starts with $0?
See the open PR referenced above. Since we use our large table extensively, it might still be good to update maxLookup for us (although probably very marginally), but in general the PR fixes the bug.
Activity
Update maxLookup
Bump maxLookup
mgutz commentedon Mar 17, 2017
Not ignoring this. I'm in a bit of time crunch right now.
lgonzalez-silen commentedon Mar 17, 2017
np! thanks
lgonzalez-silen commentedon Mar 17, 2017
See the open PR referenced above. Since we use our large table extensively, it might still be good to update maxLookup for us (although probably very marginally), but in general the PR fixes the bug.