MustPing with timeout #58

Activity

1. mgutz commented on Feb 15, 2017

   

   mgutz

   on Feb 15, 2017

   Owner

   More actions

   The convention in Go is anything prefixed by "Must" will panic. If you'd like to submit a PR for a ShouldPing function, I can add that.
2. heynemann commented on Feb 15, 2017

   

   heynemann

   on Feb 15, 2017

   Author

   More actions

   I totally agree, the problem here is not that it won't panic (although I will send a PR with ShouldPing as I'd rather have that). The problem here is that it will never panic. It will just keep retrying time after time to ping.

   I looked at the backoff lib and it has a MaxElapsedTime property that can be used for this purpose, like:

   func shouldPing(db *sql.DB, timeout time.Duration) error {
   	var err error
   	b := backoff.NewExponentialBackOff()
   	b.MaxElapsedTime = timeout
   	ticker := backoff.NewTicker(b)
   
   	// Ticks will continue to arrive when the previous operation is still running,
   	// so operations that take a while to fail could run in quick succession.
   	for range ticker.C {
   		if err = db.Ping(); err != nil {
   			continue
   		}
   
   		ticker.Stop()
   		return nil
   	}
   
   	return fmt.Errorf("Could not ping database!")
   }
   

   I'm doing a PR now! :)
3. heynemann commented on Feb 15, 2017

   

   heynemann

   on Feb 15, 2017

   Author

   More actions

   Created PR #59.