Repository navigation
Bind task_showcase to 127.0.0.1 by default - #79
Open
Harun Khan (harunkkhan) wants to merge 1 commit into
Open
Harun Khan (harunkkhan) wants to merge 1 commit into
Harun Khan (harunkkhan) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72.
assets/task_showcase/app.pydefaulted--hostto0.0.0.0, exposing the showcase on every network interface, while both READMEs documenthttp://127.0.0.1:5005. This changes the default to127.0.0.1and adds a line toassets/task_showcase/README.mdnoting that--host 0.0.0.0exposes it on the network.Note: this is a behavior change for anyone who relied on the old default to reach the showcase from another machine; they now need to pass
--host 0.0.0.0explicitly. The internal launcher insrc/cuawright/webwright/config/task_showcase.yamlalready passes--host 127.0.0.1and is unaffected. PR #67 also touchesapp.py(different lines); happy to rebase if it lands first.Testing: ran
python app.pywith no arguments;lsofshows it listening only on127.0.0.1:5005and/returns 200.