Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pinned azldev version rejects the newly added architectures keys as unknown fields.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Makes supported architectures explicit for every image and updates the vendored schema accordingly.
Changes:
- Declares architectures for all images.
- Restricts Gen1 images to
x86_64. - Requires
architecturesin the schema.
File summaries
| File | Description |
|---|---|
base/images/images.toml |
Adds per-image architecture lists. |
external/schemas/azldev.schema.json |
Requires the new image field. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
binujp
force-pushed
the
bphilip/image-arch-support
branch
from
September 10, 2026 18:32
8457453 to
6e504c9
Compare
binujp
changed the title
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned azldev version rejects the newly added configuration field.
Review details
Suppressed comments (1)
base/images/images.toml:19
- The repository is still pinned by
.azldev-versionto azldev commitfaaa0f4…, whoseImageConfighas noarchitecturesfield and whose normal config loader rejects unknown TOML fields. Consequently, loadingbase/project.tomlwith the pinned CLI will fail on this first declaration (and every azldev command that loads the project config is affected). Please update.azldev-versionto a compatible azldev revision in this PR before adding these keys.
architectures = ["x86_64", "aarch64"]
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Tobias Brick (tobiasb-ms)
approved these changes
Sep 18, 2026
Declare each Azure Linux image's supported architectures explicitly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f91d50d8-beef-4a67-a321-beba16e98506
binujp
force-pushed
the
bphilip/image-arch-support
branch
from
September 24, 2026 00:44
92e5502 to
8e2d2a1
Compare
binujp
marked this pull request as ready for review
September 24, 2026 00:45
| [images.vm-base] | ||
| description = "VM Base Image" | ||
| definition = { type = "kiwi", path = "AzureLinux.kiwi", profile = "vm-base" } | ||
| architectures = ["x86_64", "aarch64"] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
The field remains optional so azldev can roll out while the Azure Linux repository change percolates everywhere.
Rationale
Explicit per-image declarations avoid implicit inheritance and make each migrated image definition self-contained.