fix(csv): warn when a data row has more columns than the header - #2391
Open
Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Open
fix(csv): warn when a data row has more columns than the header#2391Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Lazizbek Ergashev (lazerg) wants to merge 2 commits into
Conversation
…ilter("error")
Review found the negative regression test for the row-width warning was
promoting every warning to an error, not just the one under test, which
could make it fail for unrelated reasons. Switch to the
catch_warnings(record=True) + simplefilter("always") pattern already used
by the other warning regression tests in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CsvConverter treats
rows[0]as the header with no validation, so a data row with extra columns just gets truncated withrow[: len(rows[0])], dropping fields silently. WizTree exports hit this in practice: their CSV starts with a one-field banner line before the real header, so every real column after the first gets dropped without any indication something went wrong.This adds a warning when that truncation happens, so the data loss is visible instead of silent. The truncation behavior itself is unchanged.
Fixes #2390